Fix all references to /var/run to just be /run#1141
Open
cgwalters wants to merge 1 commit intokubereboot:mainfrom
Open
Fix all references to /var/run to just be /run#1141cgwalters wants to merge 1 commit intokubereboot:mainfrom
cgwalters wants to merge 1 commit intokubereboot:mainfrom
Conversation
On any modern system `/var/run` should just be a compat symlink to `/run`. For this project it's probably fine as is, but it can matter in cases where the compat symlink might not be present yet. Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
|
Well, this changes the default for many. I am not against it, but i am afraid of breaking expectations. Do you have a use case recently that warrant it? Or should we simply do this to align to modern times? |
Collaborator
|
We will need to update rebootSentinel in the helm chart too for consistency. I would welcome a PR on the helm chart repo containing the change on rebootSentinel and a helm chart version bump. The helm chart would ideally be merged post release of kured for consistency with cli flags ... but it's optional imo. |
evrardjp
added
the
FEATURE-v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On any modern system
/var/runshould just be a compat symlink to/run.For this project it's probably fine as is, but it can matter in cases where the compat symlink might not be present yet.